Use Prism::ParseResult#continuable? if possible#1184
Merged
tompng merged 1 commit intoruby:masterfrom Mar 15, 2026
Merged
Conversation
st0012
approved these changes
Mar 14, 2026
st0012
reviewed
Mar 14, 2026
tompng
force-pushed
the
prism_termination_check
branch
from
65c31c6 to
70d548c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prism-head have
Prism::ParseResult#continuable?ruby/prism#3530 ruby/prism#3954 (It's not released yet though)RubyLex#check_code_statewill use this new API to classify syntax errors.When using older Prism,
IRB::RubyLexfallbacks to the legacy error message based heuristics. This heuristic was fragile but since we're only using it inPrism <= 1.9.0, error message won't change in the future.